MannXo commented on issue #71847: URL: https://github.com/apache/airflow/issues/71847#issuecomment-5346415666
Verified the `fab 3.8.1rc1` item for #71624 (docs fix for #71569). Setup: Airflow 3.3.1 with `apache-airflow-providers-fab==3.8.1rc1` on Python 3.12, installed against the 3.3.1 constraints file with the fab pin removed so the RC could go in without dragging pre-release builds of SQLAlchemy and friends along. `FabAuthManager` enabled, `AUTH_TYPE = AUTH_OAUTH`, one `google` entry in `OAUTH_PROVIDERS` with dummy credentials. What the running RC does: 1. Starting the flow at `/auth/login/google` redirects to the IdP with `redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fauth%2Foauth-authorized%2Fgoogle`. That is exactly the path the corrected docs now tell you to register. 2. `GET /auth/oauth-authorized/google` is a real route (302). 3. `GET /oauth-authorized/google`, the path the docs gave before, returns 200 with the UI shell, byte-identical to what a nonsense path returns, because the SPA catch-all serves it. So the old instructions never failed loudly: the IdP redirected to a page that looked fine and the login simply never completed. The corrected text is present at the `providers-fab/3.8.1rc1` tag. Separately, while setting this up I hit a second problem in the same guide, not related to this release. Step 1 of the SSO page still says to set `auth_manager` in the `[webserver]` section. On 3.3.1 that key is silently ignored, you stay on `SimpleAuthManager`, and no warning is emitted; the option lives in `[core]`. I will send a follow-up PR for it. I only tested my own item, not the rest of the fab list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
