1fanwang commented on issue #71847:
URL: https://github.com/apache/airflow/issues/71847#issuecomment-5361335761

   Tested `apache-airflow-providers-microsoft-psrp==3.2.7rc1` from PyPI for 
https://github.com/apache/airflow/pull/70347 on Airflow 3.3.1 and Python 3.12.
   
   I parsed the same Dags against 3.2.6 and the RC. Stable rejected 
provided-but-empty options and accepted equal values for `command` and 
`powershell`. The RC loaded the empty options, rejected the duplicate options, 
and kept a command that rendered to `""` on the command dispatch path.
   
   The Dag parse used Airflow's real `DagBag`. I isolated the transport for the 
dispatch check because no Windows WinRM endpoint was available.
   
   <details><summary>Raw evidence</summary>
   
   ```console
   == PSRP 3.2.6 baseline ==
   provider=3.2.6
   
operator_file=/usr/python/lib/python3.12/site-packages/airflow/providers/microsoft/psrp/operators/psrp.py
   valid_empty_options_loaded=False errors=["ValueError: Must provide exactly 
one of 'command', 'powershell', or 'cmdlet'"]
   equal_options_rejected=False errors=[]
   rendered_empty_command_dispatched=None
   
   == PSRP 3.2.7rc1 ==
   provider=3.2.7rc1
   
operator_file=/usr/python/lib/python3.12/site-packages/airflow/providers/microsoft/psrp/operators/psrp.py
   valid_empty_options_loaded=True errors=[]
   equal_options_rejected=True errors=["ValueError: Must provide exactly one of 
'command', 'powershell', or 'cmdlet'"]
   rendered_empty_command_dispatched=True
   ```
   
   </details>
   
   Addressed.
   
   ---
   Drafted-by: GitHub Copilot CLI (GPT-5.6 Sol) (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to