SEPURI-SAI-KRISHNA commented on issue #72117: URL: https://github.com/apache/airflow/issues/72117#issuecomment-5435655430
Tested `amazon 9.35.1rc1`, both of my PRs in this RC verify OK. - [x] Use the operator's AWS settings for deferred SageMaker tasks (#71857) - [x] Use the configured region for deferred Neptune cluster tasks (#71646) **How I tested** Installed the RC from PyPI into a clean venv (`apache-airflow==3.3.1`, `apache-airflow-providers-amazon==9.35.1rc1`) and ran the deferral tests from `main` against the installed wheel, not against a source checkout, so this exercises what actually ships: ``` 92 passed ``` To confirm the tests are actually sensitive to the fix, I re-ran the same suite against `9.35.0` (the release immediately before this one): ``` 9 failed, 83 passed ``` The 9 failures are exactly the deferral-configuration tests added by the two PRs, 7 SageMaker (`training`, `transform`, `processing`, `tuning`, `endpoint`, and both pipeline operators) and 2 Neptune (`NeptuneStartDbClusterOperator`, `NeptuneStopDbClusterOperator`). The other 83 tests pass identically on both versions, so nothing unrelated moved. I also checked the shipped source directly. In `9.35.0`, `operators/sagemaker.py` and `operators/neptune.py` contain zero occurrences of `region_name=self.region_name`; in `9.35.1rc1` there are 7 and 2 respectively, each accompanied by `verify=self.verify` and `botocore_config=self.botocore_config`. That matches the intended change: a deferred task now reaches AWS with the same region, SSL-verification setting and botocore config as the synchronous path, instead of silently falling back to boto3 defaults in the triggerer. --- Drafted-by: Claude Code (Opus 5); reviewed by @SEPURI-SAI-KRISHNA before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
