MannXo commented on issue #72117: URL: https://github.com/apache/airflow/issues/72117#issuecomment-5440991406
Tested `fab 3.8.1rc2`, my item in this RC verifies OK. - [x] Fix FAB SSO guide's non-working OAuth configuration instructions (#71852) **How I tested** Installed the RC from PyPI into a clean venv (`apache-airflow==3.3.1`, `apache-airflow-providers-fab==3.8.1rc2`) against the 3.3.1 constraints file with the fab pin removed, so the RC goes in without pre-release builds of SQLAlchemy and friends coming with it. Since this PR changes instructions rather than code, the test is whether the instructions work. I extracted the Google example verbatim out of the shipped `sso.rst` at the `providers-fab/3.8.1rc2` tag rather than retyping it, dropped it into a fresh `AIRFLOW_HOME`, and followed the guide as written: - `airflow config get-value core auth_manager` resolves to `FabAuthManager` from `[core]` in `airflow.cfg`, so step 1 works - API server starts, health endpoint returns 200 - the provider renders on the login page - `/auth/login/google` redirects to the IdP with `redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fauth%2Foauth-authorized%2Fgoogle` - `/auth/oauth-authorized/google` is a real route (302) As a control I ran the pre-fix instructions, taken from `sso.rst` at the `providers-fab/3.8.1rc1` tag, against this same RC package: - `[webserver] auth_manager` resolves to `SimpleAuthManager`. There is no deprecation mapping for that spelling, so the setting is silently discarded. - `AIRFLOW__FAB__OAUTH_PROVIDERS` leaves the API server unable to start: `KeyError: 'OAUTH_PROVIDERS'`. That holds even with `auth_manager` forced correctly through the environment, so it is the provider config alone that breaks it. Same package both times, so the difference is the documentation, which is what the PR changed. The shipped `sso.rst` at the rc2 tag has no remaining `[webserver] auth_manager`, `AIRFLOW__FAB__OAUTH_PROVIDERS` or `[fab] oauth_providers` references. #71624 is already ticked from the previous round; its corrected redirect path is confirmed again by the `redirect_uri` above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
