rjgoyln commented on issue #72144: URL: https://github.com/apache/airflow/issues/72144#issuecomment-5439344787
Hi @SEPURI-SAI-KRISHNA, thanks for driving this! I ran an AST sweep on `main` and wanted to share two important findings to help shape the rollout: **1. Critical Rollout Constraint (Crash Risk)** Because the triggerer deserializes via `trigger_class(**deserialised_kwargs)`, we **must** update the trigger `__init__` signatures to accept these parameters *before* or *alongside* the operator fixes. If an operator starts forwarding a real `region_name` to a trigger that hasn't been updated to accept it, the triggerer will hard-crash with a `TypeError` (currently, they don't crash because `None` values are dropped from the payload). **2. Scope Corrections** * **Missed (EMR):** `EmrContainerOperator` (line 642) and `EmrContainerSensor` (line 323) were missed because their triggers are built inside conditional expressions. * **False Positive (SageMaker):** `SageMakerNotebookOperator` is a plain `BaseOperator` that lacks `region_name`, `verify`, or `botocore_config`. It should be excluded from this scope. * **Signature Count:** Only about 30 subclasses actually have fully closed signatures that need fixing, not 54 (e.g., DMS triggers have some partially open signatures). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
