SEPURI-SAI-KRISHNA commented on issue #72144: URL: https://github.com/apache/airflow/issues/72144#issuecomment-5440375061
It does, yes, I have it working locally across all of them: 113 of 114 defer sites, the one exception being `SageMakerNotebookOperator`, which is a different shape and out of scope. But I'd rather not take the whole issue off the table for the workshop, and it splits cleanly if that's more useful to you. The reason the remaining sites can't just be fixed one call at a time is that most of the trigger subclasses never accept `region_name` / `verify` / `botocore_config` at all, and each builds its own hook from `aws_conn_id` alone. So I'd propose landing only the mechanism: - `AwsBaseWaiterTrigger` builds the hook itself from the parameters it already serializes, driven by an `aws_hook_class` attribute, the same arrangement `AwsBaseHookMixin` gives the operators. - An invariant test that walks every defer site in the provider and fails if one doesn't forward its hook configuration, carrying an allowlist of the services not yet migrated. That's roughly 200 lines and no behaviour change on its own. Each service then becomes a self-contained first contribution: set `aws_hook_class` on the triggers, widen their `__init__`, pass the three parameters at the call sites, delete one entry from the allowlist and watch that service's tests go green. Sized by defer sites and trigger classes: | service | sites | trigger classes | |---|---|---| | emr | 17 | 11 | | bedrock | 12 | 8 | | eks | 9 | 6 | | dms | 7 | 6 | | glue | 6 | 3 | | comprehend | 4 | 2 | | rds | 4 | 3 | | ecs | 2 | 2 | | batch | 1 | 1 | | opensearch_serverless | 1 | 1 | | sagemaker_unified_studio_notebook | 1 | 1 | The small ones at the bottom are a gentle first PR; emr and bedrock are better suited to someone who has already done one. Happy either way, say the word and I'll open it as the mechanism only, or as the complete fix if you'd rather just have it done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
