ferruzzi commented on code in PR #71802:
URL: https://github.com/apache/airflow/pull/71802#discussion_r3867702670
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -438,6 +439,13 @@ class VariableInterval:
key: str
def resolve(self) -> timedelta:
+ warnings.warn(
+ "VariableInterval.resolve() is deprecated and will be removed in a
future release. "
+ "Deadline interval resolution is handled internally during
deadline evaluation.",
+ DeprecationWarning,
Review Comment:
Maybe just a nit since I don't know if this is actually enforced, but are we
supposed to be using `RemovedInAirflow4Warning` now? I'm not sure, I just saw
it in another PR but it doesn't look like there's any kind of CI enforcing
that, so maybe it's situational. May be worth changing either way, up to you.
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
Review Comment:
Credit where it is due, Claude caught this one: This whole mock can go
now. It was only needed so `AirflowRuntimeError` could read them. You can
drop this whole mock setup then just use `side_effect=KeyError("missing_key"),`
down on line 1558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
