IcebreakerSA commented on code in PR #72590:
URL: https://github.com/apache/airflow/pull/72590#discussion_r3950048768
##########
airflow-ctl/src/airflowctl/ctl/help_texts.yaml:
##########
@@ -15,6 +15,11 @@
# specific language governing permissions and limitations
# under the License.
---
+arguments:
+ reprocess-behavior: >-
+ Select which Dag runs to create: 'none' (Missing Runs), 'failed' (Missing
and Errored Runs),
+ or 'completed' (All Runs). Default is 'none'.
+
Review Comment:
Agreed. I removed the argument-level mapping and restored this file's group
→ subcommand → description contract. Since the airflowctl follow-up was
non-blocking and there is no existing mechanism for argument-specific help, I
am keeping this PR focused instead of introducing a new abstraction for one
flag.
Thank you for catching this.
---
Drafted-by: OpenAI Codex (GPT-5) (no human review before posting)
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -725,10 +726,12 @@ def _create_arg_for_non_primitive_type(
commands.append(
self._create_arg(
-
arg_flags=(f"--{self._sanitize_arg_parameter_key(field)}",),
+ arg_flags=(f"--{sanitized_field}",),
arg_type=self._python_type_from_string(annotation),
arg_action=argparse.BooleanOptionalAction if annotation is
bool else None, # type: ignore
- arg_help=f"{field} for {parameter_key} operation",
+ arg_help=self.help_texts.get("arguments", {}).get(
Review Comment:
Agreed. I removed the per-flag lookup and the associated generator changes,
so generated flags retain their previous behavior.
---
Drafted-by: OpenAI Codex (GPT-5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
