IcebreakerSA commented on code in PR #72590:
URL: https://github.com/apache/airflow/pull/72590#discussion_r3950116391
##########
airflow-ctl/src/airflowctl/ctl/help_texts.yaml:
##########
@@ -15,6 +15,11 @@
# specific language governing permissions and limitations
# under the License.
---
+arguments:
+ reprocess-behavior: >-
+ Select which Dag runs to create: 'none' (Missing Runs), 'failed' (Missing
and Errored Runs),
+ or 'completed' (All Runs). Default is 'none'.
+
Review Comment:
Thank you for explaining the intended structure of this file. This is my
first open-source contribution, and I appreciate you taking the time to point
this out.
I agree that the argument-level mapping did not fit the existing group →
subcommand → description contract. I have removed the airflowctl addition and
restored the PR to its original three-file scope.
---
Drafted-by: OpenAI Codex (GPT-5); reviewed by @IcebreakerSA before posting
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -725,10 +726,12 @@ def _create_arg_for_non_primitive_type(
commands.append(
self._create_arg(
-
arg_flags=(f"--{self._sanitize_arg_parameter_key(field)}",),
+ arg_flags=(f"--{sanitized_field}",),
arg_type=self._python_type_from_string(annotation),
arg_action=argparse.BooleanOptionalAction if annotation is
bool else None, # type: ignore
- arg_help=f"{field} for {parameter_key} operation",
+ arg_help=self.help_texts.get("arguments", {}).get(
Review Comment:
Agreed. I have removed the per-generated-flag lookup and the associated
generator changes. Thank you again for the review.
---
Drafted-by: OpenAI Codex (GPT-5); reviewed by @IcebreakerSA before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
