nandeshkanagaraju commented on issue #72902: URL: https://github.com/apache/airflow/issues/72902#issuecomment-5630108093
Tested **amazon 9.36.0rc1** for [Fix region_name being ignored by the Step Functions execution trigger (#72625)](https://github.com/apache/airflow/pull/72625) — works as expected ✅ Installed the RC from PyPI into a clean venv (Python 3.12, `apache-airflow==3.3.1`, `apache-airflow-task-sdk==1.3.1`) and verified against the installed distribution (not a source checkout), with `AWS_DEFAULT_REGION=us-east-1` so a regression would be visible: - `StepFunctionsExecutionCompleteTrigger(execution_arn=..., region_name="eu-west-1")` → `trigger.region_name == "eu-west-1"`, and the hook the deferred waiter polls with builds a boto3 client in `eu-west-1`. - `serialize()` round-trip keeps `region_name`, and the rebuilt trigger still polls `eu-west-1` (so the region survives a triggerer restart). - With no `region_name` passed, it still falls back to the connection/env default (`us-east-1`) — no regression for existing DAGs. - End-to-end via `StepFunctionStartExecutionOperator(deferrable=True, region_name="eu-west-1")`: the `TaskDeferred` trigger carries the region and polls `eu-west-1`. - The unit tests added in the PR (`providers/amazon/tests/unit/amazon/aws/triggers/test_step_function.py`) pass against the RC wheel: `3 passed`. Negative control on the previous release `9.35.1` reproduces the original bug — `trigger.region_name` is `None` and the waiter client is created in `us-east-1` despite `region_name="eu-west-1"` being passed. Thanks for preparing the release! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
