SEPURI-SAI-KRISHNA commented on issue #72902:
URL: https://github.com/apache/airflow/issues/72902#issuecomment-5634058335

   Tested my change in **google 22.5.0rc1** and it works as expected.
   
   Clean venv, Python 3.12, `apache-airflow==3.3.1`, provider installed from 
PyPI and verified to be resolved out of `site-packages` rather than a source 
checkout. Wheel sha256 matched the PyPI digest 
(`7290bff16b8242f0aa57adb293ec6b9412f5e5d19538cc6ce8208af90d9fffdd`).
   
   [Honor impersonation_chain in deferred Cloud Build tasks 
(#71644)](https://github.com/apache/airflow/pull/71644): 
`CloudBuildCreateBuildTrigger._get_async_hook()` now builds 
`CloudBuildAsyncHook` with the impersonation chain, so the deferred half 
authenticates as the impersonated service account rather than the connection's 
own.
   
   - single account: `hook.impersonation_chain == 
'[email protected]'`
   - delegated list: both entries preserved in order
   - serialize round-trip, which is how the triggerer actually rebuilds the 
trigger: the chain survives and the rebuilt trigger's hook still carries it
   - no chain configured: stays `None`, so nothing is invented where none was 
set
   
   I also ran the same script against **22.4.0**, the release before the fix, 
where `hook.impersonation_chain` comes back `None`. So the change is doing the 
work rather than passing vacuously.
   
   ---
   
   While here I also checked **amazon 9.36.0rc1** for [Pass verify and 
botocore_config to GlueJobCompleteTrigger 
(#72557)](https://github.com/apache/airflow/pull/72557), since my issue 
[#72144](https://github.com/apache/airflow/issues/72144) is linked to it. 
Working as expected: a deferrable `GlueJobSensor` configured with 
`region_name='eu-west-1'`, `verify='/path/to/ca-bundle.pem'` and 
`botocore_config={'read_timeout': 42}` now hands all three to 
`GlueJobCompleteTrigger`, and the hook the trigger builds carries them 
(`hook.verify`, `hook.region_name`, and `read_timeout=42` on the botocore 
config).
   
   One note for anyone reading the linked issue rather than the PR: #72557 
covers the two Glue call sites, not the whole of #72144. The remaining services 
are still in flight, so #72144 should stay open after this release.
   
   ---
   Drafted-by: Claude Code (Opus 5); reviewed by @SEPURI-SAI-KRISHNA before 
posting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to