justinpakzad commented on code in PR #71976:
URL: https://github.com/apache/airflow/pull/71976#discussion_r3997567147
##########
providers/influxdb/pyproject.toml:
##########
@@ -61,8 +61,11 @@ requires-python = ">=3.10"
dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-common-compat>=1.8.0",
+ 'pandas>=2.1.2; python_version <"3.13"',
+ 'pandas>=2.2.3; python_version >="3.13" and python_version <"3.14"',
+ 'pandas>=2.3.3; python_version >="3.14"',
Review Comment:
Pandas is listed as a required dependency here but based on one of your
previous comments and the `_import_pandas` guard in the hook, it seems like it
should be optional. If it's meant to be a required dependency then I think we
can drop the guard in the hook.
##########
providers/influxdb/src/airflow/providers/influxdb/operators/influxdb3.py:
##########
@@ -49,24 +53,50 @@ def __init__(
*,
sql: str,
influxdb3_conn_id: str = "influxdb3_default",
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
**kwargs,
) -> None:
super().__init__(**kwargs)
self.influxdb3_conn_id = influxdb3_conn_id
self.sql = sql
+ self.deferrable = deferrable
- def execute(self, context: Context) -> list[dict[str, Any]]:
+ def execute(self, context: Context) -> list[dict[str, Any]] | None:
Review Comment:
I don't think the this ever returns `None`. When it hits the deferrable
branch it raises a `TaskDeferred`, so we can remove the annotation and also
clean up the docstring below.
##########
providers/influxdb/src/airflow/providers/influxdb/_utils.py:
##########
Review Comment:
This is a style nit but none of the other providers use private util
modules, the convention seems to just be `utils.py`. Maybe worth updating? The
function itself can remain private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
