kaxil commented on code in PR #73193:
URL: https://github.com/apache/airflow/pull/73193#discussion_r4017183079
##########
providers/amazon/tests/system/amazon/aws/example_dms.py:
##########
@@ -45,7 +45,12 @@
RdsDeleteDbInstanceOperator,
)
from airflow.providers.amazon.aws.sensors.dms import DmsTaskBaseSensor,
DmsTaskCompletedSensor
-from airflow.providers.standard.sensors.date_time import DateTimeSensorAsync
+
+try:
+ from airflow.providers.standard.sensors.date_time import
DateTimeSensorAsync
+except ImportError:
+ # Fallback for older Airflow versions
+ from airflow.sensors.date_time import DateTimeSensorAsync # type:
ignore[no-redef]
Review Comment:
Good question! The standard provider actually predates Airflow 3 :) It
landed in https://github.com/apache/airflow/pull/41564 in Sep 2024 and was
first released as 0.0.1 in Nov 2024 with `apache-airflow>=2.8.0`, and we
CI-tested it against 2.8/2.9 in https://github.com/apache/airflow/pull/43556.
Today `providers/standard` requires `apache-airflow>=2.11.0`, which is the
same floor `providers/amazon` has, so I don't think there's a supported
combination where amazon works but standard isn't installable (amazon also
already lists it as an extra). And the fallback target
`airflow.sensors.date_time` is the old pre-move location, so the `except`
branch would only kick in on Airflow <= 2.7, which is below our floor.
That said, did you hit an actual ImportError somewhere? If the standard
provider just isn't installed in the environment where you saw this, happy to
help sort that out instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
