vincbeck commented on PR #73193: URL: https://github.com/apache/airflow/pull/73193#issuecomment-5686106693
> And the fallback target `airflow.sensors.date_time` is the old pre-move location, so the `except` branch would only kick in on Airflow <= 2.7, which is below our floor. This is the part I'd push back on — `airflow.sensors.date_time` is still live in 2.11, not just a pre-2.8 location. In the `2.11.0` tag, `airflow/sensors/date_time.py` natively defines both `DateTimeSensor` (line 32) and `DateTimeSensorAsync` (line 81): full implementations, no re-export from the standard provider, no deprecation shim, no warning. The move out of core only completed in Airflow 3, so core kept these modules for the whole 2.x line. That means the `except` branch resolves fine on 2.11 — it's the branch my run above actually takes. On "installable": `providers/amazon` lists the standard provider as an optional extra rather than a dependency, so amazon-on-2.11 without standard installed is a supported combination, not a broken one. That's the combination we're deliberately exercising, to catch anything in the amazon provider that quietly leans on standard. Worth noting this pattern is already established in the amazon system tests — three files use the identical `try` / `except ImportError` for `BashOperator`, down to the same comment: - `providers/amazon/tests/system/amazon/aws/example_appflow.py:30` - `providers/amazon/tests/system/amazon/aws/example_http_to_s3.py:24` - `providers/amazon/tests/system/amazon/aws/utils/k8s.py:21` `airflow.operators.bash` is equally live in 2.11 core, so those three fall under the same reasoning as this change. This PR is bringing `example_dms` in line with them rather than introducing something new. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
