SameerMesiah97 commented on code in PR #73212:
URL: https://github.com/apache/airflow/pull/73212#discussion_r4019062864
##########
airflow-ctl/tests/airflow_ctl/api/test_client.py:
##########
@@ -550,6 +550,24 @@ def
test_credentials_rejects_unsafe_env_from_environment_variable(monkeypatch, a
class TestRetryConfigurationEnvVars:
"""The knobs are read at import time, so a bad value used to take down
even ``--help``."""
+ @pytest.fixture(autouse=True)
+ def unique_config_dir(self, monkeypatch, tmp_path):
+ """
+ Override the module fixture, which clears ``os.environ`` wholesale.
+
+ These tests hand the environment to a child interpreter, and starting
one needs more
+ than ``AIRFLOW_HOME``: a ``--enable-shared`` Python cannot find
``libpython`` without
+ the ``LD_LIBRARY_PATH`` its installer exported. Only the knobs under
test are dropped,
+ so a value in the developer's own shell cannot decide the result.
Review Comment:
Now, I am seeing this in a lot of AI-assisted PRs and don't consider this
blocking but don't you see that the dosctrings generated by these AI tools are
far too long? My understanding is that the docstring should very briefly
explain what the function does. Not go deep into the implementation details or
further context (that is what comments are for).
If possible, I would see if you could adjust the agent you are using to
avoid these long docsrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
