shahar1 commented on code in PR #73212:
URL: https://github.com/apache/airflow/pull/73212#discussion_r4019126548
##########
airflow-ctl/tests/airflow_ctl/api/test_client.py:
##########
@@ -550,6 +550,24 @@ def
test_credentials_rejects_unsafe_env_from_environment_variable(monkeypatch, a
class TestRetryConfigurationEnvVars:
"""The knobs are read at import time, so a bad value used to take down
even ``--help``."""
+ @pytest.fixture(autouse=True)
+ def unique_config_dir(self, monkeypatch, tmp_path):
+ """
+ Override the module fixture, which clears ``os.environ`` wholesale.
+
+ These tests hand the environment to a child interpreter, and starting
one needs more
+ than ``AIRFLOW_HOME``: a ``--enable-shared`` Python cannot find
``libpython`` without
+ the ``LD_LIBRARY_PATH`` its installer exported. Only the knobs under
test are dropped,
+ so a value in the developer's own shell cannot decide the result.
Review Comment:
Generally I agree that we should reduce AI commentary to bare minimum
(current system prompt in CLADUE.md/AGENTS.md is far from optimized, so even if
it's mentioned there it might be overlooked).
Specifically in this case I don't think that it's too bad (although it could
be optimized) - because there should be justification of why we override the
fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
