pierrejeambrun commented on code in PR #73126:
URL: https://github.com/apache/airflow/pull/73126#discussion_r4036927512
##########
ts-sdk/src/cli/pack.ts:
##########
@@ -194,6 +212,11 @@ export async function runPack(argv: readonly string[]):
Promise<void> {
platform: "node",
format: "esm",
target: "node22",
+ // A digest is only worth taking over an artifact nobody reads or edits
in place.
+ minify: true,
+ // Keep handler and class names in the stack traces a failing task
reports.
+ keepNames: true,
Review Comment:
I don't think we want that. Can we take a look at an 'onLoad' step in the
build process to actually bind the 'string' (functionName) somewher before the
builder does anything, therefore it will survive minifying. (I don't think
there is an interface to hook directly into the minify process).
(Before going down that road we need to make sure it's not complicating the
code too much or making it hard to maintain, but I'd love an investigation just
to explore the possibility)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
