jason810496 commented on code in PR #73126:
URL: https://github.com/apache/airflow/pull/73126#discussion_r4043614859
##########
ts-sdk/src/cli/pack.ts:
##########
@@ -194,6 +212,11 @@ export async function runPack(argv: readonly string[]):
Promise<void> {
platform: "node",
format: "esm",
target: "node22",
+ // A digest is only worth taking over an artifact nobody reads or edits
in place.
+ minify: true,
+ // Keep handler and class names in the stack traces a failing task
reports.
+ keepNames: true,
Review Comment:
Agreed, we can drop the `keepNames`.
In the case of mixed language TaskHandler, since user need to explicitly
mention task_id (`new TaskHandler(dagId, taskId, handler)`), so it's fine to
minify without keeping the function name.
In the case of native Dag: Even with [Default the TypeScript task id to the
handler function name #73243](https://github.com/apache/airflow/pull/73243),
the `onLoad` hook is sufficient to transform the `const extract =
dag.task(async function extract() ... {` to explicit task_id `const extract =
dag.task(async function extract() ..., { taskId: "extract"});`, before minify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
