diegoalvarez-clarity commented on PR #70180: URL: https://github.com/apache/airflow/pull/70180#issuecomment-5728534703
Thanks for the thorough review, @Miretpl. All comments are addressed in three commits, one per area: the helper reuse (1342d421ee), the values and schema wording plus the newsfragment removal (8ef39ae7a5), and the test rework (05572dab2e). The directory-mount test now covers all ten templates that include the config mount, and the default-behaviour test renders with no values. On the airflow_local_settings.py point I replied on the thread with why the path is unchanged and added an assertion for it. I've also removed the misleading reference to the other issue. Sorry for the confusion. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
