diegoalvarez-clarity commented on code in PR #70180:
URL: https://github.com/apache/airflow/pull/70180#discussion_r4045753272
##########
chart/templates/_helpers.yaml:
##########
@@ -645,7 +649,16 @@ server_tls_key_file = /etc/pgbouncer/server.key
{{- printf "%s-config" (include "airflow.fullname" .) }}
{{- end }}
+{{- define "airflow_config_dir" -}}
+ {{- printf "%s/config" .Values.airflowHome | quote }}
+{{- end }}
+
{{- define "airflow_config_mount" -}}
+{{- if .Values.mountConfigAsDir }}
Review Comment:
Correct. With the flag on the whole subPath branch is skipped, including the
conditional airflow_local_settings.py mount. The file still lands at the same
path because airflow_local_setting_path already resolves inside the mounted
directory. test_mount_config_as_dir now asserts, on every component, exactly
one directory config mount and no airflow.cfg or airflow_local_settings.py
subPath (05572dab2e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
