YAshhh29 commented on code in PR #71575:
URL: https://github.com/apache/airflow/pull/71575#discussion_r4048366758
##########
providers/common/ai/src/airflow/providers/common/ai/durable/caching_model.py:
##########
@@ -112,6 +114,11 @@ async def request(
)
response = await self.wrapped.request(messages, model_settings,
model_request_parameters)
+ if fingerprint is None:
+ # Storing this would write an entry the guard above can never
accept,
+ # once per step, each write rewriting the whole cache blob.
Review Comment:
Both done. You're right that the blob rewrite is an `ObjectStorage` detail
and this class only holds a `DurableStorageProtocol`, with
`TaskStateStoreDurableStorage` setting a single key — so that half is gone.
What's left ("an entry the guard can never accept") makes the point without
naming a backend.
Agreed the marker was the more useful half. `fingerprint_model_request` and
`fingerprint_tool_call` now both take a keyword-only `step` and attach it to
their warnings, so the string the docs point at names the step at production
log levels instead of only the debug line carrying it. It defaults to `None`,
so existing calls still work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
