YAshhh29 commented on code in PR #71575:
URL: https://github.com/apache/airflow/pull/71575#discussion_r4048400716
##########
providers/common/ai/docs/operators/agent.rst:
##########
@@ -300,6 +300,17 @@ cache:
never replays responses that belong to a different conversation.
4. After successful completion, the cached steps are deleted.
+If a model request or tool call cannot be fingerprinted -- it carries a value
+that will not serialize to JSON -- that step is not cached, and on retry it
runs
+live rather than replaying an unverified entry. This is rarely confined to a
+single step: the usual causes are a non-serializable value in
``model_settings``,
Review Comment:
Fair — the `_digest` normalization takes care of the dominant tool-call
cause, so that part mostly resolves itself, but the paragraph was still wrong
to open by covering both paths and then only give model-path causes.
It's now three parts:
a) normalization first, so a `datetime` or `Decimal` argument isn't
presented as a hazard at all,
b) then the model path, where `model_settings` and message history make it
run-wide,
c) then tool calls on their own, noting they're fingerprinted from name,
args and call id alone and report `could not fingerprint tool call`.
The quoted strings now match what each path actually emits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
