kaxil commented on PR #73030: URL: https://github.com/apache/airflow/pull/73030#issuecomment-5840504664
Approving. The masking now happens in the worker, where the secret is registered, and the items from the earlier rounds are all in. Nothing below needs to hold the merge. - `schedule_tis` bumps `try_number` without clearing `retry_reason` ([dagrun.py:2302-2308](https://github.com/apache/airflow/blob/8d35e368924579ac1e48f25c474be0d398609275/airflow-core/src/airflow/models/dagrun.py#L2302-L2308)), and the only reset is in `ti_run`. When the next try fails before it starts, which the stuck-in-queued limit ([scheduler_job_runner.py:3357](https://github.com/apache/airflow/blob/8d35e368924579ac1e48f25c474be0d398609275/airflow-core/src/airflow/jobs/scheduler_job_runner.py#L3357)) and an executor-reported failure on a queued TI ([:1772](https://github.com/apache/airflow/blob/8d35e368924579ac1e48f25c474be0d398609275/airflow-core/src/airflow/jobs/scheduler_job_runner.py#L1772)) both do, the row keeps the previous try's reason and the Header banner shows "Stopped on try 3 of 4" over try 2's text. Could the staleness follow-up cover `schedule_tis` as well as `clear_task_instances`? Adding `retry_reason=None` to its UPDATE is enough, since the retry branch arch ives the earlier try with its reason before that runs. - The comment on the `state_reason` validator went stale with this push, because `_evaluate_retry_policy` now redacts every reason. What the validator still guards is a reason written by an older task-sdk, which is worth saying so nobody later removes it as redundant. Same in `task_instance_history.py`. - `from dataclasses import replace` in `_evaluate_retry_policy` can move to the top of the file; `dataclasses` is stdlib with no cycle. - The `as Record<string, ...>` cast in `stateReason.ts` lets a misspelt state compile and then never display. `Partial<Record<TaskInstanceState, ...>>` would turn that into a compile error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
