amoghrajesh commented on PR #73030:
URL: https://github.com/apache/airflow/pull/73030#issuecomment-5869403483
Thanks, folks. Did the last 3.
1. Validator comment now says what it actually guards: the worker redacts;
this only catches rows from an older task-sdk. Same note on the history copy.
2. Moved import to top.
3. `stateReason.ts` is now `Partial<Record<TaskInstanceState, ...>>` with
the cast gone. A misspelt state is a compile error - checked it: `error TS2561:
... 'up_for_retryy'` does not exist.
That last one turned up something worth knowing: the root tsconfig.json is
`{"files": [], "references": [...]}`, so `tsc -p tsconfig.json` checks nothing
at all. Even a blatant type error passes. The real check is `tsc -p
tsconfig.app.json`, which is what `pnpm lint` runs. I'd been using the wrong
one. Re-ran the right one across everything here: clean.
On schedule_tis: good catch, and worse than the cases we already knew about,
since the counts and the reason come from different attempts rather than just
being stale. Taking it into the clearing follow up alongside
`clear_task_instances`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
