jeff3071 commented on code in PR #71437:
URL: https://github.com/apache/airflow/pull/71437#discussion_r4109977053


##########
providers/common/ai/src/airflow/providers/common/ai/hooks/pydantic_ai.py:
##########
@@ -151,12 +182,16 @@ def __init__(
         # argument values at class-definition time.
         self.llm_conn_id = llm_conn_id if llm_conn_id is not None else 
self.default_conn_name
         self.model_id = model_id
+        self.embed_conn_id = embed_conn_id if embed_conn_id is not None else 
self.llm_conn_id
+        self.embed_model_id = embed_model_id
         # ``None`` means "not configured here, read the connection's extra";
         # an empty list means "explicitly no fallbacks", overriding the extra.
         self.fallback_conn_ids = fallback_conn_ids

Review Comment:
   Order them follow the docstring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to