jeff3071 commented on code in PR #71437:
URL: https://github.com/apache/airflow/pull/71437#discussion_r4109989854


##########
providers/common/ai/tests/unit/common/ai/hooks/test_pydantic_ai.py:
##########
@@ -115,25 +128,47 @@ class TestPydanticAIHookInit:
     def test_default_conn_id(self):
         hook = PydanticAIHook()
         assert hook.llm_conn_id == "pydanticai_default"
+        assert hook.embed_conn_id == "pydanticai_default"
         assert hook.model_id is None
+        assert hook.embed_model_id is None
 
     def test_custom_conn_id(self):
-        hook = PydanticAIHook(llm_conn_id="my_llm", 
model_id="openai:gpt-5.6-sol")
+        hook = PydanticAIHook(
+            llm_conn_id="my_llm",
+            model_id="openai:gpt-5.6-sol",
+            embed_model_id="openai:text-embedding-3-small",
+            embed_conn_id="my_embeddings",
+        )
         assert hook.llm_conn_id == "my_llm"
+        assert hook.embed_conn_id == "my_embeddings"
         assert hook.model_id == "openai:gpt-5.6-sol"
+        assert hook.embed_model_id == "openai:text-embedding-3-small"
 
     def test_azure_hook_uses_own_default_conn_name(self):

Review Comment:
   Parameterized "provider" tests (Azure, Bedrock, Vertex).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to