jason810496 commented on code in PR #73437:
URL: https://github.com/apache/airflow/pull/73437#discussion_r4115808368
##########
ts-sdk/src/sdk/dag.ts:
##########
@@ -560,6 +632,54 @@ function spreadArgs(fn: TaskFunction): TaskFunction {
handler(...Object.values(args ?? {}))) as unknown as TaskFunction;
}
+// What Airflow accepts as a task id, and so what a name taken from a handler
+// has to look like.
+const TASK_ID_CHARACTERS = /^[\p{L}\p{N}_.-]+$/u;
Review Comment:
I agreed, the TS side should handle at build time since the server will
validate at Dag processing stage eventually. I'd like to have a follow-up to
solve it once the core is wired up.
Tracked in https://github.com/apache/airflow/issues/73800 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
