pierrejeambrun commented on code in PR #73437:
URL: https://github.com/apache/airflow/pull/73437#discussion_r4131593183
##########
ts-sdk/adr/0002-native-dag-interface.md:
##########
@@ -181,17 +180,19 @@ convention.
- **The spec argument already has its slot.** `dag.task(taskId, handler,
options)` reads `{ spec = {} }`
and runs `validateEmptySpec` on it (`ts-sdk/src/sdk/dag.ts`), so task fields
land on a path that
exists rather than a new one.
-- **A positional argument binds by order, and its name is a label.** The
serialized Dag names each
- argument, so the packer reads the names from the handler's parameter list;
`arg0`, `arg1` and so on
- stand in for a name it cannot see, without changing which value reaches
which argument.
+- **A listed call binds by order, and the names still come from the handler.**
The serialized Dag
+ names every argument, so `withArgList(...)` is zipped with the keys the
handler destructures, read
Review Comment:
Can we drop the withArgList all together and only enforce 'object
destructuring` pattern at first.
I feel like it's more aligned with modern TS library and will make this a
lot simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
