ashb commented on code in PR #73836:
URL: https://github.com/apache/airflow/pull/73836#discussion_r4121893029
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -323,9 +324,9 @@ def _get_project_names(shell_params: ShellParams) ->
tuple[str, str]:
"""Return compose project name and project name."""
project_name = file_name_from_test_type(shell_params.test_type)
if shell_params.test_type == ALL_TEST_TYPE:
- compose_project_name = "breeze-airflow-test"
+ compose_project_name = f"{shell_params.project_name}-airflow-test"
else:
- compose_project_name = f"breeze-airflow-test-{project_name}"
+ compose_project_name =
f"{shell_params.project_name}-airflow-test-{project_name}"
Review Comment:
Everything else uses `breeze` as the project name, so `breeze shelll
--project-name foobar` would create a container
`foobar-airflow-run-111a6cd3b78d`, So I've just kept that convention for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
