Andrushika commented on code in PR #73836:
URL: https://github.com/apache/airflow/pull/73836#discussion_r4124746963
##########
scripts/ci/docker-compose/backend-postgres.yml:
##########
Review Comment:
Looks like this path never matched the correct directory... It should be
`..../${POSTGRES_VERSION}/docker`, but currently the `$` is in the bracket.
And as I know, Postgres 18 and all versions <= 17 use different PGDATA
directories; could we also fix it here?
About Postgres version and PGDATA path:
https://github.com/docker-library/docs/blob/master/postgres/README.md#pgdata
##########
dev/breeze/doc/05_test_commands.rst:
##########
@@ -108,6 +108,20 @@ For example this will run API and WWW tests in parallel:
breeze testing core-tests --parallel-test-types "API WWW" --run-in-parallel
+When testing separate worktrees concurrently, give each invocation a different
+``--project-name``. This isolates its containers, networks, and database
volumes.
+The option also applies to ``breeze testing providers-tests``.
+
+.. code-block:: bash
+
+ breeze testing core-tests --project-name breeze-history --backend postgres
+ breeze testing core-tests --project-name breeze-clearing --backend postgres
+
+If you use this mode you will have to clean up old projects manually:
+
+.. code-block:: bash
+ breeze down --project-name breeze-history
Review Comment:
It seems like Breeze will add a suffix to the project name.
e.g. `breeze testing core-tests --project-name breeze-history --backend
postgres` will create a project named
`breeze-history-airflow-test-<test-type>`.
So developers cannot simply type `breeze down` with the project name
`breeze-history`, and I found it kinda inconvenient.
I guess developers won't know these project names, and since most of the
test volumes are only used "once", what if we make the test runner remove its
own volumes when the run finishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
