bbovenzi commented on code in PR #73913:
URL: https://github.com/apache/airflow/pull/73913#discussion_r4146072621
##########
airflow-core/src/airflow/ui/src/layouts/Nav/NavButton.tsx:
##########
@@ -115,12 +115,12 @@ export const NavButton = ({
if (isExternal) {
return (
- <Link asChild href={to} rel="noopener noreferrer" target="_blank">
- <Button {...commonButtonProps}>
+ <Button {...commonButtonProps} asChild>
Review Comment:
Why not `<Button as="a"`?
##########
airflow-core/newsfragments/73913.bugfix.rst:
##########
Review Comment:
We can remove the bugfix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
