vaishsriram commented on code in PR #73913:
URL: https://github.com/apache/airflow/pull/73913#discussion_r4146239182
##########
airflow-core/src/airflow/ui/src/layouts/Nav/NavButton.tsx:
##########
@@ -115,12 +115,12 @@ export const NavButton = ({
if (isExternal) {
return (
- <Link asChild href={to} rel="noopener noreferrer" target="_blank">
- <Button {...commonButtonProps}>
+ <Button {...commonButtonProps} asChild>
Review Comment:
`as` was removed in Chakra UI v3, `asChild` is the replacement. The internal
link branch just above this already uses `<Button asChild><RouterLink>`, so
this mirrors that same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
