kaxil commented on PR #73470:
URL: https://github.com/apache/airflow/pull/73470#issuecomment-5940884331

   Closing this. Instead of skipping, the change leaves the task to 
`NotPreviouslySkippedDep` "on the next scheduler pass", but that dep only waits 
when `dep_context.wait_for_past_depends_before_skipping` is true, and nothing 
in the scheduler sets it: `DepContext` defaults it to `False`, and the contexts 
built in `dagrun.py` don't pass it. So the task is still skipped, one loop 
later. The new tests are `SkipMixin` unit tests with mocks, and none shows the 
downstream task staying unscheduled, which is what #55146 asks for.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to