zozo123 commented on code in PR #71672:
URL: https://github.com/apache/airflow/pull/71672#discussion_r4182766386


##########
providers/common/ai/docs/connections/islo.rst:
##########
@@ -0,0 +1,85 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+.. _howto/connection:islo:
+
+Islo Connection
+===============
+
+The ``islo`` connection type holds the API key and endpoints for
+`islo.dev <https://islo.dev>`__, the hosted microVM sandbox service behind
+:class:`~airflow.providers.common.ai.sandbox.IsloSandboxBackend`. It backs
+:class:`~airflow.providers.common.ai.hooks.islo.IsloHook` (see
+:doc:`../hooks/islo` for hook usage and installation instructions).
+
+Default Connection IDs
+----------------------
+
+``IsloHook`` and ``IsloSandboxBackend`` use ``islo_default`` by default.
+
+Configuring the Connection
+---------------------------
+
+API Key (Password field)
+    An Islo API key, created with ``islo api-key create`` or in the Islo
+    dashboard. Required.
+
+Compute URL (Host field)
+    Optional. The regional compute API the microVMs run on, passed to the SDK
+    as ``compute_url=``. The SDK default is ``https://ca.compute.islo.dev``.
+
+API URL (Extra field)
+    Optional. The control-plane URL, passed as ``base_url=``. The SDK default
+    is ``https://api.islo.dev``. Stored in ``extra["base_url"]``.
+
+Request Timeout (Extra field)
+    Optional. HTTP request timeout in seconds, applied to every SDK call.

Review Comment:
   Done at `c56450a6ff`. `connections/islo.rst` now says `extra.timeout` only 
affects direct use of the hook's client, and that `IsloSandboxBackend` sets a 
timeout on every call itself, bounded by the command deadline, and 120 seconds 
for file transfers.
   
   ---
   Drafted-by: Cursor agent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to