zozo123 commented on code in PR #71672: URL: https://github.com/apache/airflow/pull/71672#discussion_r4183449167
########## providers/common/ai/src/airflow/providers/common/ai/hooks/islo.py: ########## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Hook for the islo.dev sandbox API.""" + +from __future__ import annotations + +import math +from typing import TYPE_CHECKING, Any + +from airflow.providers.common.compat.sdk import BaseHook + +if TYPE_CHECKING: + from islo import Islo + + +class IsloHook(BaseHook): Review Comment: `IsloHook` and the `islo` connection type are removed in 0e1fbdd814. `IsloSandboxBackend()` reads `ISLO_API_KEY`, and optionally `ISLO_BASE_URL` and `ISLO_COMPUTE_URL`, from the worker environment on first use. That is the same credential shape Modal uses in this provider. A hook and connection type can land later in an Islo provider, the way #73418 moved Modal's. Fields Islo cannot enforce stay refused at `create`. Those are a hostname allowlist, a CIDR allowlist, `owner`, and `PATH`. Drafted-by: Cursor agent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
