ashb commented on code in PR #74222:
URL: https://github.com/apache/airflow/pull/74222#discussion_r4184040738
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -639,7 +675,9 @@ class TaskInstance(Base, LoggingMixin, BaseWorkload):
duration: Mapped[float | None] = mapped_column(Float, nullable=True)
state: Mapped[str | None] = mapped_column(String(20), nullable=True)
try_number: Mapped[int] = mapped_column(Integer, default=0)
- max_tries: Mapped[int] = mapped_column(Integer, server_default="-1")
+ max_tries: Mapped[int] = mapped_column(Integer, server_default="-1",
nullable=False)
+ working_set: Mapped[bool | None] = mapped_column(Boolean, default=True,
server_default=true())
Review Comment:
Oh I wasn't aware of `with_loader_criteria`. That's nice. It only covers ORM
cases, not direct "core" queries (which we use in a few places in Exec API for
instance for speed) but it helps a lot, as the default case is "no historic
data) far more than not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
