ashb commented on code in PR #74222:
URL: https://github.com/apache/airflow/pull/74222#discussion_r4186911845
##########
airflow-core/src/airflow/api/common/delete_dag.py:
##########
@@ -55,8 +55,10 @@ def delete_dag(dag_id: str, keep_records_in_log: bool =
True, *, session: Sessio
log.info("Deleting Dag: %s", dag_id)
running_tis = session.scalar(
select(models.TaskInstance.state)
- .where(models.TaskInstance.dag_id == dag_id)
- .where(models.TaskInstance.state == TaskInstanceState.RUNNING)
+ .where(
+ models.TaskInstance.dag_id == dag_id,
+ models.TaskInstance.state == TaskInstanceState.RUNNING,
+ )
Review Comment:
Oh this has now become a pointless change now that the `with_loader_options`
means we are auto filtering to working set only TIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
