kaxil commented on code in PR #74159:
URL: https://github.com/apache/airflow/pull/74159#discussion_r4188202614
##########
airflow-core/docs/start.rst:
##########
@@ -24,11 +24,11 @@ This quick start guide will help you bootstrap an Airflow
standalone instance on
.. note::
- Successful installation requires a Python 3 environment. Starting with
Airflow 3.2.0, Airflow supports Python 3.10, 3.11, 3.12, 3.13, 3.14.
+ Successful installation requires a Python 3 environment. Starting with
Airflow 3.2.0, Airflow supports Python 3.11, 3.12, 3.13, 3.14.
Review Comment:
This now reads as if 3.2.0 onwards supports 3.11 to 3.14 only, but the 3.2.0
and 3.3.0 tags and `v3-4-test` all declare `requires-python = ">=3.10,!=3.15"`.
Could we drop the "Starting with Airflow 3.2.0" anchor, or name the release
that actually drops 3.10?
##########
contributing-docs/07_local_virtualenv.rst:
##########
@@ -36,7 +36,7 @@ Required Software Packages
Use system-level package managers like yum, apt-get for Linux, or
Homebrew for macOS to install required software packages:
-* Python (One of: 3.10, 3.11, 3.12, 3.13, 3.14)
+* Python (One of: 3.11, 3.12, 3.13, 3.14)
Review Comment:
The examples further down still use `uv python install 3.10.7` and `uv venv
--python 3.10.7` (lines 105, 109, 129). With `requires-python` now `>=3.11`,
the venv those commands create can't install Airflow.
##########
dev/breeze/doc/01_installation.rst:
##########
@@ -399,7 +399,7 @@ that Breeze works on
.. code-block:: bash
- UV_PYTHON=3.10 breeze ...
+ UV_PYTHON=3.11 breeze ...
Review Comment:
The same note still has `UV_PYTHON=3.10.16 breeze ...` (line 438), `uv tool
install --python 3.10.16` (447) and the pipx `3.10.16` interpreter path (453).
Breeze now requires `>=3.11`, so following those commands fails to install it.
Could they move to a 3.11.x version as well?
##########
docker-stack-docs/build.rst:
##########
@@ -736,23 +736,23 @@ Building from PyPI packages
This is the basic way of building the custom images from sources.
-The following example builds the production image in version ``3.10`` with
latest PyPI-released Airflow,
+The following example builds the production image in version ``3.11`` with
latest PyPI-released Airflow,
Review Comment:
The scripts included here build with `AIRFLOW_PYTHON_VERSION="3.13.15"` or
the Dockerfile default (also 3.13.15), so "version ``3.11``" here and at lines
747, 755 and 782 doesn't describe what they build. The old 3.10 was wrong as
well. Saying "the default Python version" would stop this drifting with each
bump.
##########
dev/breeze/doc/14_advanced_breeze_topics.rst:
##########
@@ -49,7 +49,7 @@ make sure to follow these steps:
this will bypass the check we run in Breeze to see if there are new
requirements to install for it
See example configuration for PyCharm which has run/debug configuration for
-``breeze sbom generate-providers-requirements --provider-id sqlite --python
3.10``
+``breeze sbom generate-providers-requirements --provider-id sqlite --python
3.11``
Review Comment:
`breeze sbom generate-providers-requirements` has no `--python` option, only
`--python-versions`, so this example fails as written.
##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -526,17 +526,17 @@ Both commands should produce reproducible `.whl`,
`.tar.gz` packages in dist fol
file containing airflow sources in dist folder.
> [!IMPORTANT]
-> Run the build with Python 3.10 — the project's
`DEFAULT_PYTHON_MAJOR_MINOR_VERSION`. The
+> Run the build with Python 3.11 — the project's
`DEFAULT_PYTHON_MAJOR_MINOR_VERSION`. The
> client generator applies the `trigger_dag_run_post_body.py` AST patch with
> `ast.unparse`, which
> re-emits that file using the running interpreter's grammar, so building
> under a different Python
> (e.g. the host's 3.11+/3.13) produces a non-reproducible client and the
> `prepare-python-client`
> step may not even emit the wheel/sdist. `prepare-python-client` refuses to
> run under any other
> Python and exits early with this guidance, so pin the interpreter explicitly:
>
> ```shell
-> UV_PYTHON=3.10 breeze release-management prepare-python-client
--distribution-format both --version-suffix ""
+> UV_PYTHON=3.11 breeze release-management prepare-python-client
--distribution-format both --version-suffix ""
> # or equivalently
-> breeze --python 3.10 release-management prepare-python-client
--distribution-format both --version-suffix ""
+> breeze --python 3.11 release-management prepare-python-client
--distribution-format both --version-suffix ""
Review Comment:
I don't think this one is equivalent.
`_ensure_default_python_for_reproducible_client` checks `sys.version_info` of
the interpreter Breeze itself runs on, and `--python` only selects the image,
so on a 3.13 host this still exits 1. Only the `UV_PYTHON` form works. Line 532
also now gives "the host's 3.11+/3.13" as an example of a different Python,
which includes the required one.
##########
dev/breeze/doc/05_test_commands.rst:
##########
@@ -802,7 +802,7 @@ be created and Airflow deployed to it before running the
tests):
.. code-block:: bash
- (kind-airflow-python-3.10-v1.24.0:KubernetesExecutor)> pytest
test_kubernetes_executor.py
+ (kind-airflow-python-3.11-v1.24.0:KubernetesExecutor)> pytest
test_kubernetes_executor.py
Review Comment:
Two lines down, `platform linux -- Python 3.10.6` still reports 3.10 while
the rest of this transcript now says 3.11.
##########
contributing-docs/03_contributors_quick_start.rst:
##########
@@ -477,7 +477,7 @@ see in CI in your local environment.
.. code-block:: bash
- breeze --python 3.10 --backend postgres
+ breeze --python 3.11 --backend postgres
Review Comment:
The next step still shows the prompt as `[Breeze:3.10.19]` (line 483), and
so do the transcripts at 493, 497, 513, 652, 664 and 760-762. Bumping those too
would keep the walkthrough consistent with this `--python 3.11` command.
##########
dev/breeze/doc/06_managing_docker_images.rst:
##########
@@ -220,10 +220,10 @@ suffix and they need to also be paired with corresponding
runtime dependency add
.. code-block:: bash
- breeze prod-image build --python 3.10 --additional-dev-deps
"libasound2-dev" \
+ breeze prod-image build --python 3.11 --additional-dev-deps
"libasound2-dev" \
Review Comment:
Since this line is being edited anyway: the option is
`--additional-dev-apt-deps` (see `common_image_options.py`).
`--additional-dev-deps` doesn't exist, so this command errors as written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
