potiuk commented on code in PR #74159: URL: https://github.com/apache/airflow/pull/74159#discussion_r4189368685
########## docker-stack-docs/docker-examples/restricted/restricted_environments.sh: ########## @@ -29,16 +29,16 @@ mkdir -p docker-context-files export AIRFLOW_VERSION="2.5.3" rm docker-context-files/*.whl docker-context-files/*.tar.gz docker-context-files/*.txt || true -curl -Lo "docker-context-files/constraints-3.10.txt" \ - "https://raw.githubusercontent.com/apache/airflow/constraints-${AIRFLOW_VERSION}/constraints-3.10.txt"; +curl -Lo "docker-context-files/constraints-3.11.txt" \ Review Comment: This example still pins `AIRFLOW_VERSION="2.5.3"`, and `constraints-2.5.3` only has `constraints-3.7`–`3.10.txt`, so this downloads a 404 page as the constraints file and `pip download` then fails. CI skips the `.sh` examples, so it won't show up there. Either bump `AIRFLOW_VERSION` to a release that has 3.11 constraints (the sibling `pypi-selected-version.sh` uses 3.0.3) or keep 3.10 for this pinned example. ########## contributing-docs/03_contributors_quick_start.rst: ########## @@ -270,8 +270,8 @@ To avoid burden on our CI infrastructure and to save time, prek hooks can be run We have recently started to recommend ``uv`` for our local development. .. note:: - Remember to have global python set to Python >= 3.10 - Python 3.10 is end-of-life already and we've - started to use Python 3.10+ features in Airflow and accompanying scripts. + Remember to have global python set to Python >= 3.11 - Python 3.10 is end-of-life already and we've Review Comment: Nit: 3.10 reaches end-of-life at the end of October, so maybe 'is reaching end-of-life'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
