potiuk commented on code in PR #74156:
URL: https://github.com/apache/airflow/pull/74156#discussion_r4189367874
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -1105,13 +1105,7 @@ def resolve_hatchling_build_requires(with_gitpython:
bool = False) -> list[str]:
"typing_extensions": "typing-extensions",
}
canonical = CANONICAL_NAMES.get(pkg_name_lower,
pkg_spec.split("==")[0])
- if pkg_name_lower == "tomli":
- requires.append(f"{canonical}=={pkg_version}; python_version <
'3.11'")
- elif pkg_name_lower == "typing_extensions":
- # typing_extensions is built-in from Python 3.11+
- requires.append(f"{canonical}=={pkg_version}; python_version <
'3.11'")
- else:
- requires.append(f"{canonical}=={pkg_version}")
+ requires.append(f"{canonical}=={pkg_version}")
Review Comment:
This collapse of the `tomli`/`typing_extensions` marker branches isn't ruff
output, while the commit message says 'Output of ruff --fix'. It's harmless,
since layer 1 already compiles with `--python-version 3.11`, and layer 7
finishes the cleanup (docstring, `CANONICAL_NAMES`). Move it there, or mention
it in the commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
