yuseok89 opened a new pull request, #74622:
URL: https://github.com/apache/airflow/pull/74622
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Clicking a tag on the Dags list replaced the whole filter. The tag link
always pointed to `/dags?tags=<name>`, so any other filter (owner, paused
state, search, folder), the tag match mode and previously selected tags were
dropped.
This makes tags in the Dags list (cards and table) work on the current
filters. Tags on the Dag details page keep their current link, since there are
no list filters to keep there.
| Before click | Clicked tag | Before | After |
|---|---|---|---|
| `Owner: alice` | `finance` | `Tags: finance` | `Owner: alice` `Tags:
finance` |
| `Tags: finance` `Owner: alice` | `daily` | `Tags: daily` | `Tags: finance,
daily` `Owner: alice` |
| `Tags: (all) finance, daily` `Owner: alice` | `daily` (selected) | `Tags:
daily` | `Tags: finance` `Owner: alice` |
| `Tags: finance` `Owner: alice` | `finance` (selected) | `Tags: finance` |
`Owner: alice` |
| `Owner: alice` (page 3) | `finance` | `Tags: finance` (page 1) | `Owner:
alice` `Tags: finance` (page 1) |
- A clicked tag is added to the selected tags, and clicking a selected tag
removes it. Selected tags are shown in bold so the toggle is visible.
- The match mode is left as the user set it, and dropped once no tag remains.
- Pagination goes back to the first page, like the search box and the folder
picker do.
With the default `any` mode, clicking a second tag widens the list
(`finance` or `daily`). An alternative is to switch to `all` on such a click,
so it narrows the current list instead. I kept the match mode untouched to
avoid changing a setting the user did not pick. Other thoughts on how tag
clicks should behave are very welcome.
### Before / After
<!-- screenshots -->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Claude Code (Opus 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
