yuseok89 commented on code in PR #74622:
URL: https://github.com/apache/airflow/pull/74622#discussion_r4265522439
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##########
@@ -80,7 +80,7 @@ export const DagCard = ({
{dag.dag_display_name}
</RouterLink>
</Tooltip>
- <DagTags tags={dag.tags} />
+ <DagTags keepListFilters tags={dag.tags} />
Review Comment:
Good idea, thanks. I dropped the prop and rebased onto main. `DagTags` now
keeps the current filters only when it is rendered on the Dags list, based on
the current path.
I didn't make it fully unconditional because of the Dag header. It stays on
every Dag tab, and the Runs tab writes its own `sort` to the URL once a column
is sorted. The Dags list reads the same key, so clicking a tag in the header
after sorting runs by Start Date went to `/dags?sort=-start_date&tags=demo` and
the Dags list showed an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
