namanjain24-sudo commented on PR #74245: URL: https://github.com/apache/airflow/pull/74245#issuecomment-6198395798
## Reply to Andrushika (PR #74245 review comment) You're right, and the PR description overstates it. `stats.initialize()` (from #63932, hardened in #68078/#68514) only covers explicit entry-point init — API server startup and the task-runner subprocess — it doesn't address the general case #69172 describes (e.g. plugin/listener hooks running in a long-running process like the scheduler, which never call `stats.initialize()` and fall back to `NoStatsLogger`). #69172 is still open, and #69270 — the fix that would have added the dynamic `import_module()` calls this exemption was reserved for — never merged either. The actual justification for removing the exemption doesn't depend on #69172 being fixed: it only depends on #69270's dynamic-import approach never having landed, so `stats.py` has zero `airflow.*` imports (static or dynamic) today, exemption or not. I'll fix the PR description to stop implying #69172 is resolved. --- Drafted-by: Claude Code (Sonnet 5); reviewed by naman before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
