dheerajturaga opened a new pull request, #75037: URL: https://github.com/apache/airflow/pull/75037
### Stack Stacks on #75036. Stack index: 5 of 20. A PR from a fork cannot target a fork branch, so each PR in the stack is based on `main` and contains every commit below it; only the top commit is new. Review only the commit "AIP-125: Discover webhook-sources from provider.yaml"; the commits below it belong to earlier PRs in the stack. ### Status Draft. [AIP-125 (Inbound Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is under discussion on dev@ and not yet voted; this stack is its proof of concept so that voters can run it, and nothing should merge before the vote. The feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) and experimental; no unauthenticated route is reachable until stack PR 18, which merges last. ### Why Source types are shipped by providers, so core finds them in provider metadata. Discovery records each declaration without importing it; the class is imported when a webhook first needs it. A source type declared more than once is served by none of its declarers: the usual first-wins rule follows package names, which would let a package that sorts earlier replace another provider's signature check. ### What to look at - The conflict rule instead of first-wins. The next PR adds `[webhooks] source_type_owners` to pick a winner. - The `provider.yaml` schema is strict (a source type is `[a-z][a-z0-9_]{0,63}`, to fit its `String(64)` column). The runtime schema leaves entries untyped so one bad entry does not drop the whole provider; `ProvidersManager` checks them instead. - `get_webhook_source_class` caches each import, failures included, and leaves the `WebhookSource` check to the caller. - New `airflow providers webhook-sources` command; the provider.yaml check fails on duplicate source types and unregistered `WebhookSource` subclasses. ### Testing - `test_providers_manager.py`, `test_provider_yaml_schema.py` and `test_provider_command.py` passed under breeze on SQLite, Postgres and MySQL. After the last fixes, the tests were rerun on SQLite and Postgres, and the final head passed again on MySQL. - `breeze build-docs` is clean for the providers summary docs. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5.5) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
