dheerajturaga opened a new pull request, #75160: URL: https://github.com/apache/airflow/pull/75160
### Stack Stacks on #75159. Stack index: 12 of 20. Its base is the branch of #75159, so the diff shows only this layer's commit, "AIP-125: Add airflow webhooks check and send-test". ### Status Draft. [AIP-125 (Inbound Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is under discussion on dev@ and not yet voted; this stack is its proof of concept so that voters can run it, and nothing should merge before the vote. The feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) and experimental; no unauthenticated route is reachable until stack PR 18, which merges last. ### Why A Deployment Manager needs to know whether a webhook can be served before pointing a sender at it, and to reproduce a sender's delivery afterwards. `check` resolves each name as the webhooks app does and exits non-zero on any problem, including a source type two providers declare. `send-test` signs one request, or sends the token, as the connection says, using the standard library; it prints the answer as JSON and never follows a redirect that would carry the secret to another host. ### What to look at - A new experimental `airflow webhooks` group, admin only, since it reads the connection's secret. - `send-test` reads the standard provider's option names (`signature_header`, `token_header` and others) from the extra. It runs outside the webhooks process and its flags override them, but it is an exception to the AIP's "core reads nothing else", which the AIP draft now names. - When `hmac_json` or `token_header` is missing, `check` names the standard provider version that ships them. ### Testing - `test_webhooks_command.py`, `test_connections.py` and `test_registry.py` passed under breeze on SQLite, Postgres and MySQL. After the last fixes, the tests were rerun on SQLite and Postgres, and the final head passed again on MySQL. - The live demo sends every signed delivery with `send-test`; it passed on Postgres and MySQL. ### Known limitations - `_MIN_STANDARD_PROVIDER_VERSION = "1.21.0"` is a guess, to set to the standard release that first ships these source types. - The proof-of-concept package 0.2 registers its own `airflow webhooks` group, which makes every `airflow` command fail next to this one; its final release must not register it when `airflow.webhooks.base` exists. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5.5) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
