yuseok89 commented on code in PR #75223:
URL: https://github.com/apache/airflow/pull/75223#discussion_r4338619485
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -204,6 +230,9 @@ const TriggerDAGForm = ({
</Field.Root>
)}
/>
+ {outsideDagDatesWarning === undefined ? undefined : (
+ <Alert status="warning">{outsideDagDatesWarning}</Alert>
+ )}
Review Comment:
Thanks for the example, the field text looks much better than the alert.
Even so, the form still moved a little when the text appeared, so I now show
the Dag start and end dates as helper text in the normal case too. The same
line turns into the warning when the logical date is outside them, so the space
stays reserved. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
