yuseok89 commented on code in PR #75223:
URL: https://github.com/apache/airflow/pull/75223#discussion_r4338707766
##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -165,6 +174,23 @@ const TriggerDAGForm = ({
const resetDateError = () => setErrors((prev) => ({ ...prev, date: undefined
}));
+ // Every task's start and end dates are bounded by the Dag's, so a run
outside them creates no
+ // task instances and is marked successful without running anything.
+ const logicalDate = watch("logicalDate");
+ const startDate = dagDetails?.start_date;
+ const endDate = dagDetails?.end_date;
+ let outsideDagDatesWarning: string | undefined;
+
+ if (Boolean(logicalDate) && typeof startDate === "string" &&
dayjs(logicalDate).isBefore(startDate)) {
Review Comment:
I think it's fine without one. They're compared as points in time rather
than as the values shown, so a local logical date lines up with the UTC dates
from the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
