uranusjr commented on code in PR #75445:
URL: https://github.com/apache/airflow/pull/75445#discussion_r4358231742
##########
ts-sdk/src/coordinator/client.ts:
##########
@@ -161,24 +162,25 @@ function toExpiresAt(ms: number): string {
const at = new Date(Date.now() + ms);
if (Number.isNaN(at.getTime()) || at.getUTCFullYear() > 9999) {
throw new RangeError(
- `retention of ${ms}ms overflows the wire timestamp; use NEVER_EXPIRE
instead`,
+ `a retention that ends ${ms}ms from now overflows the wire timestamp; ` +
+ "use NEVER_EXPIRE instead",
Review Comment:
The user now passes seconds, but this error reports milliseconds. Have
`toExpiresAt` take seconds and convert it at L183, or format the message in
seconds instead so it matches what the caller passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
