uranusjr commented on code in PR #75445:
URL: https://github.com/apache/airflow/pull/75445#discussion_r4358238172
##########
ts-sdk/src/sdk/client-types.ts:
##########
@@ -63,14 +63,14 @@ export const NEVER_EXPIRE: unique symbol =
Symbol("apache-airflow-ts-sdk/NEVER_E
/** Options for a task state store write. */
export interface TaskStateStoreSetOpts {
/**
- * Milliseconds to retain the key, counted from the write; `0` expires it
+ * Seconds to retain the key, counted from the write; `0` expires it
* immediately.
*
* Omitting it follows the deployment's `[state_store]
default_retention_days`,
* which the coordinator passes to the runtime. Pass {@link NEVER_EXPIRE} to
* store the key with no expiry regardless of that default.
*/
- retentionMs?: number | typeof NEVER_EXPIRE;
+ retentionSeconds?: number | typeof NEVER_EXPIRE;
Review Comment:
Other public durations are bare names in seconds, and the Python counterpart
is `retention`. `retentionSeconds` follows `awaitInput({ timeoutSeconds })`
instead. Either works, but we should commit to one convention or the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
