pingzh commented on a change in pull request #7141: [AIRFLOW-6544] add log_id to end-of-file mark and also add an index config for logs URL: https://github.com/apache/airflow/pull/7141#discussion_r368095723
########## File path: tests/utils/log/test_es_task_handler.py ########## @@ -262,21 +277,55 @@ def test_set_context_w_json_format_and_write_stdout(self): self.es_task_handler.json_format = True self.es_task_handler.set_context(self.ti) - def test_close(self): - formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s') Review comment: i think we should not remove this test as it is still a valid test case with the formatter set ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services